fix(hashing): bad SHAKE length crashes the page #32
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
needs-info
needs-triage
question
ready-for-agent
ready-for-human
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
flopana/OpenDevTools#32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #30
Branch:
feature/improve-hashingBugs
HashingGenComp.tsxpassesNumber(e.target.value)from the SHAKE length inputs toshake128andshake256. Inputs-1and1.5throw"outputLen" expected integer >= 0during render.src/has no ErrorBoundary, so the page goes blank. Input999999999asks for about 1 GB and freezes the tab.Verification: the review agent reproduced the throw in node. The freeze and the slow rehash are not measured.
Red tests
-1,1.5and999999999do not crash and do not freeze.Fix
MAX_SHAKE_LEN. Addminandmaxto the input.useMemokeyed on the input bytes and the two lengths.